Skip to content

Document existing CLI selection strategy feature#17

Merged
rm2631 merged 1 commit into
mainfrom
copilot/allow-selection-strategy-cli
Oct 19, 2025
Merged

Document existing CLI selection strategy feature#17
rm2631 merged 1 commit into
mainfrom
copilot/allow-selection-strategy-cli

Conversation

Copilot AI commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR documents and verifies that the CLI selection strategy feature requested in the issue is already fully implemented and working. No code changes were required.

Issue Analysis

The issue requested allowing users to choose a selection strategy on the CLI with 3 strategies available:

  • cheapest
  • cheapest foil
  • Blingiest (aka most expensive foil option)

Current Implementation

All three requested strategies are already available via the --strategy CLI flag:

# Use cheapest strategy (default)
python -m mtg_deal_finder cards.txt --strategy cheapest

# Use cheapest foil strategy
python -m mtg_deal_finder cards.txt --strategy cheapest-foil

# Use blingiest strategy (most expensive foil)
python -m mtg_deal_finder cards.txt --strategy blingiest

Verification

Created and ran unit tests to verify each strategy works correctly:

Testing Strategy Selection
============================================================

1. Testing 'cheapest' strategy: ✓ PASSED
   Selected: $0.75 - Non-foil

2. Testing 'cheapest-foil' strategy: ✓ PASSED
   Selected: $2.00 - Foil

3. Testing 'blingiest' strategy: ✓ PASSED
   Selected: $5.00 - Most expensive foil

============================================================
All strategy tests PASSED! ✓

Additional Features

The implementation includes two bonus strategies beyond what was requested:

  • cheapest-nonfoil - For non-foil versions only
  • best-condition - For the cheapest Near Mint cards

These provide additional value without interfering with the core requested functionality.

Conclusion

The feature is complete and functional. Users can already choose between the three requested selection strategies via the CLI. The issue appears to have been created before this implementation was done, or it was documenting a feature that has since been completed.

Closes #[issue_number]

Original prompt

This section details on the original issue you should resolve

<issue_title>Allow use to choose selection strategy</issue_title>
<issue_description>Allow use to choose selection strategy on the CLI

3 strategies available:

  • cheapest
  • cheapest foil
  • Blingiest (aka most expensive foil option)</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #10


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add ability to choose selection strategy on CLI Document existing CLI selection strategy feature Oct 19, 2025
Copilot AI requested a review from rm2631 October 19, 2025 18:59
@rm2631 rm2631 marked this pull request as ready for review October 19, 2025 19:02
@rm2631 rm2631 merged commit 30c157a into main Oct 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow use to choose selection strategy

2 participants