1714 conditional tag cmp working on two properties#1735
1714 conditional tag cmp working on two properties#1735Jo-Be-Co wants to merge 5 commits intormcrackan:masterfrom
Conversation
|
still need to add documentation and some more tests |
|
However, the changes have already been implemented to the extent that a review is possible – I’m open to feedback and requests for adjustments. |
|
Overall this looks good. There are some broken tests related to |
| [DataRow("<!cmp author != 'Sherlock'->false<-cmp>", "")] | ||
| [DataRow("<cmp tag = 'Tag1'->true<-cmp>", "true")] | ||
| [DataRow("<cmp tag[separator(:)slice(-2..)] = 'Tag2:Tag3'->true<-cmp>", "true")] | ||
| [DataRow("<cmp tag[separator( : )slice(-2..)] = 'Tag2 : Tag3'->true<-cmp>", "true")] |
There was a problem hiding this comment.
For clarity, can you include this test with and without the spaces
|
Your latest commit looks nice. |
|
In fact, I would have liked to avoid the parsing of the property and leave it to the later evaluation. However, situations will always come (like the : ) in which the blanket collection no longer works. Especially because, for example, everything possible can be used as a delimiter. Therefore, the regular expression must then take into account the syntax with '...', "..." and [...]. All with somewhat different escape behaviour. And even so, we can't guarantee everything here ... |
Did you intend to target the mathematical operations and symbols? |
Not sure what you mean, so I assume the answer is no. |
|
Based on your comment that my last commit looks nice, I first thought that you meant the corrections on the regular expression and then had the feeling that I finally actually added the comparisons for lists and the operators Anyway, syntax is actually just a proposal. As this new |
|
Nope. I meant addressing the |
2 participants
No description provided.