Skip to content

Drop table lock around copyout. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riastradh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop table lock around copyout. #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/kern/npf_tableset.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,15 +736,17 @@ table_ent_copyout(const npf_addr_t *addr, const int alen, npf_netmask_t mask,
}

static int
table_generic_list(const npf_table_t *t, void *ubuf, size_t len)
table_generic_list(npf_table_t *t, void *ubuf, size_t len)
{
npf_tblent_t *ent;
size_t off = 0;
int error = 0;

LIST_FOREACH(ent, &t->t_list, te_listent) {
mutex_exit(&t->t_lock);
error = table_ent_copyout(&ent->te_addr,
ent->te_alen, ent->te_preflen, ubuf, len, &off);
mutex_enter(&t->t_lock);
if (error)
break;
}
Expand Down