fix(message): allow bulk message media content properties#159
Open
WT-March wants to merge 1 commit into
Open
Conversation
BulkMessageContentDto declared image/video/audio/document without any class-validator decorator. With the global ValidationPipe set to forbidNonWhitelisted, these undecorated properties were treated as non-whitelisted, so every send-bulk request was rejected with "property image should not exist" — even plain text batches that never included a media key. Add @IsOptional() to image/video/audio/document so they are whitelisted optional properties. Text and media bulk sends now validate correctly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
POST /sessions/:id/messages/send-bulkrequest was rejected with:even for plain text batches that never included any media key.
Cause
BulkMessageContentDtodeclaresimage/video/audio/documentwith only@ApiPropertyOptional()and no class-validator decorator. The globalValidationPiperuns withforbidNonWhitelisted: true, so class-validator treats those undecorated fields as non-whitelisted and rejects the nestedcontentobject.Fix
Add
@IsOptional()to the four media properties so they become whitelisted optional fields. Text and media bulk sends now validate correctly.Test
Verified locally against a connected session: text bulk batch returns
status=completed, sent=1, failed=0and the message is delivered.?? Generated with Claude Code