fix: add message ack handling and sent message webhooks#178
Open
Singh1106 wants to merge 1 commit into
Open
Conversation
- Update onMessageAck engine callback to accept full IncomingMessage instead of just message ID and ack - Implement onMessageAck handler in SessionService to log acks, update session activity, and dispatch webhook events - Add webhook dispatch for all outgoing messages in MessageService - Refine onMessage handler in SessionService to properly distinguish sent vs received messages - Add WebhookModule dependency to MessageModule - Clean up peer dependency metadata in package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the missing
message.sentwebhook event reported in #93. Even with all webhook configurations enabled andmessage.sentsubscribed, no webhook was being fired for outgoing messages. The root cause was thatMessageServicenever dispatched a webhook after sending, andSessionService'sonMessagehandler wasn't distinguishing sent vs received messages. This PR adds the webhook dispatch for outgoing messages, updates theonMessageAckcallback to carry the full message payload, and wiresWebhookModuleintoMessageModule.Type of Change
Checklist
Screenshots (if applicable)
Related Issues
Closes #93