labels: simplify completion for labels #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsekman
force-pushed
the
label-completions
branch
from
a6dcb29 to
87a1082
Compare
Owner
|
Thanks!
I made some changes to `labels()` that should make it more efficient. But I don't use labels, so
it's not straightforward for me to test it works as intended.
Can you confirm current master works?
|
Contributor
Author
|
Current master looks to me like it works as expected. Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callers of
completion.candidates.labels()were trying to do something that the completion engine already can handle (separate several values in one argument). In addition, the crash in #263 occurs on Python 3.14.labelsnow creates aCandidatesobject much like thefs_pathandsort_orderscandidate generators do.