Conversation
NcUltimate
reviewed
May 27, 2020
| } | ||
| defer os.Remove(tmpfile.Name()) // clean up | ||
|
|
||
| if _, err := tmpfile.WriteString(timeoutStatements(c)); err != nil { |
Contributor
There was a problem hiding this comment.
Do the timeouts need to be reset after each migration?
Owner
Author
There was a problem hiding this comment.
Yes, since each migration runs through a separate invocation of psql and thus a new connection.
Owner
Author
There was a problem hiding this comment.
On the pq driver, when the connection doesn't change, not necessarily -- but it does prevent any in-migration overrides from bleeding through to the next migration.
This functionality is critical for applying patches to large, active databases in an automated context. If you don't need it, set the timeouts to -1.
rnubel
force-pushed
the
lock-retry-loop
branch
from
7bf5134 to
db29d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality is critical for applying patches to large, active databases in an automated context. The default values here are battle-tested against Enova's busiest database, but can be fully customized. If you don't need the behavior at all, set the timeouts and max retries to -1.