Fix session model persistence and default reasoning behavior#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
node_modules/.bin/vitest run src/__tests__/unit/tui/session-model-sync.test.ts src/__tests__/unit/tui/local-commands.test.ts src/__tests__/unit/core/openai-oauth.test.ts src/__tests__/unit/core/chat-turn-runtime.test.tsnode_modules/.bin/vitest run src/__tests__/integration/tui/ask-cli.test.ts -t "runs a stateless ask|creates a new session|continues an existing session|preflight compacts"node_modules/.bin/vitest run src/__tests__/integration/chat/chat-runtime.test.ts -t "clears explicit reasoning effort when control-plane settings send null"yarn buildyarn eslint src/cli/chat/App.tsx src/cli/chat/utils/session-model-sync.ts src/core/llm/model-policy.ts src/__tests__/unit/tui/session-model-sync.test.ts src/__tests__/unit/tui/local-commands.test.ts src/__tests__/unit/core/openai-oauth.test.tsNotes
This does not yet centralize model and reasoning ownership. The next step should be a focused refactor around session execution preferences so new-session defaults, session persistence, ask mode, and UI state all share one owner.