Refactor chat session boundaries and host hook layout#74
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bc2d5c268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type UseChatSessionsArgs = { | ||
| sessionCatalogFile: string; | ||
| apiKeyPresent: boolean; | ||
| defaultModel: string; | ||
| workspaceRoot: string; | ||
| stateRoot: string; | ||
| }; |
There was a problem hiding this comment.
Keep chat session storage path configurable
The session hook no longer accepts sessionCatalogFile and now always builds its service config from stateRoot, which hardwires persistence to stateRoot/chat-sessions.catalog.json. This breaks callers that provide a non-default catalog path (for example embedding runtimes), and it can desynchronize state because turn execution still reads from runtime.sessionCatalogFile in the run controller path. Please thread the runtime-provided session catalog path through useChatSessions so both session CRUD and turn execution target the same file.
Useful? React with 👍 / 👎.
Summary
Verification