[codex] Refactor conversation compaction boundary#84
Merged
Conversation
Move compaction out of the history folder into a first-class engine domain, remove the unused legacy deterministic compaction path, and expose ConversationCompactionService.compact as the single service entrypoint. Group persisted context fields around request, compaction, and archive state to reduce field-by-field mapping, and split archive summarizer prompt/context/service into a dedicated submodule.
Replace remaining external long-relative imports to the compaction engine domain with the src path alias while keeping local one-level imports inside the compaction module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/core/chat/engine/compaction/domain and remove the oldhistory/compaction.tsmodule.ConversationCompactionService.compact(...)is the single compaction entrypoint.request,compaction, andarchivestate to reduce repeated field mapping across engine, TUI, and control-plane surfaces.Validation
yarn typecheckyarn test src/__tests__/integration/tui/ask-cli.test.ts src/__tests__/unit/core/conversation-engine.test.ts src/__tests__/unit/core/chat-turn-persistence.test.ts src/__tests__/unit/core/chat-turn-runtime.test.ts src/__tests__/integration/chat/chat-runtime.test.ts src/__tests__/unit/tui/daemon.test.tsyarn lintyarn build