feat: enhance PluginFactory with properties management#104
Merged
chirino merged 1 commit intoroastedroot:mainfrom Jul 17, 2025
Merged
feat: enhance PluginFactory with properties management#104chirino merged 1 commit intoroastedroot:mainfrom
chirino merged 1 commit intoroastedroot:mainfrom
Conversation
- Added a properties field to the PluginFactory.Builder for managing plugin properties. - Introduced methods `withProperties` and `withProperty` to set multiple or single properties respectively. - Updated the Plugin constructor to accept properties and ensure they are properly initialized. - return a value for the pluign_root_id property This commit enhances the PluginFactory by allowing users to define and manage properties for plugin instances. The new methods facilitate easier configuration of properties, improving the flexibility and usability of the PluginFactory. This change is expected to streamline the process of setting up plugins with specific configurations, ultimately leading to a more robust implementation of the proxy-wasm functionality. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withPropertiesandwithPropertyto set multiple or single properties respectively.This commit enhances the PluginFactory by allowing users to define and manage properties for plugin instances. The new methods facilitate easier configuration of properties, improving the flexibility and usability of the PluginFactory. This change is expected to streamline the process of setting up plugins with specific configurations, ultimately leading to a more robust implementation of the proxy-wasm functionality.