Add support for doing http calls from the plugin /w the jaxrs filter.#37
Add support for doing http calls from the plugin /w the jaxrs filter.#37chirino merged 1 commit intoroastedroot:mainfrom
Conversation
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
| assertNotNull(plugin); | ||
|
|
||
| var logger = (MockLogger) plugin.logger(); | ||
| Thread.sleep(300); |
There was a problem hiding this comment.
Would it be possible to trigger plugin.close() instead waiting here?
There was a problem hiding this comment.
We basically have to wait for the tick events to get delivered to the plugin. . They are getting delivered every 100 ms (configured by the plugin). If we want avoid the wait, we would need to implement a new wasm module, avoiding the use of the async tick event to trigger the http call.
There was a problem hiding this comment.
I see, thanks for explaining, (the config is not in the diff).
A Thread.sleep always makes me a little anxious should we use Awaitility or something similar to avoid this becoming flaky over time?
There was a problem hiding this comment.
Yeah.. I think I might just implement a better wasm plugin that allows us to test things better.
2 participants
No description provided.