fix: resolve javadoc reference errors causing build failures#94
Merged
chirino merged 2 commits intoroastedroot:mainfrom Jun 3, 2025
Merged
fix: resolve javadoc reference errors causing build failures#94chirino merged 2 commits intoroastedroot:mainfrom
chirino merged 2 commits intoroastedroot:mainfrom
Conversation
• Fixed broken javadoc reference in StartException.java from Plugin.Builder#build() to PluginFactory.Builder#build() • Fixed broken javadoc reference in PluginFactory.java from Plugin#builder() to PluginFactory#builder() • Moved maven-javadoc-plugin configuration from release profile to main pluginManagement for consistent execution • Ensured javadoc generation runs during all builds, not just release builds This commit resolves Maven build failures that were occurring at release due to invalid javadoc cross-references. The references were pointing to non-existent Plugin.Builder class methods when they should have been pointing to the correct PluginFactory.Builder methods. Additionally, the javadoc plugin configuration was moved to ensure consistent documentation generation across all build profiles, improving the overall build reliability and documentation quality. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Fixed broken javadoc reference in StartException.java from Plugin.Builder#build() to PluginFactory.Builder#build() • Fixed broken javadoc reference in PluginFactory.java from Plugin#builder() to PluginFactory#builder() • Moved maven-javadoc-plugin configuration from release profile to main pluginManagement for consistent execution • Ensured javadoc generation runs during all builds, not just release builds
This commit resolves Maven build failures that were occurring at release due to invalid javadoc cross-references. The references were pointing to non-existent Plugin.Builder class methods when they should have been pointing to the correct PluginFactory.Builder methods. Additionally, the javadoc plugin configuration was moved to ensure consistent documentation generation across all build profiles, improving the overall build reliability and documentation quality.