Skip to content
This repository was archived by the owner on Nov 26, 2019. It is now read-only.

Fix crash for single station trip#4

Open
timroesner wants to merge 7 commits intorobbiet480:masterfrom
timroesner:master
Open

Fix crash for single station trip#4
timroesner wants to merge 7 commits intorobbiet480:masterfrom
timroesner:master

Conversation

@timroesner
Copy link
Copy Markdown

@timroesner timroesner commented Aug 6, 2019

  • Fix crash for TripDetails when ExitTimestamp is unavailable
  • Properly zoom Map for trips with only one station
  • Add app icon
  • Fix crash which occurs after a repeated tag scan
  • Routes do not seem to correspond to actual Route

I'll work on this more this week, also have some stations that I'll try to add to the top-level repo

@robbiet480
Copy link
Copy Markdown
Owner

@timroesner For the crash on repeated tag scan... I noticed that too tonight. It was never an issue before, so my assumption is its a bug in beta 5, but could be wrong.

@timroesner
Copy link
Copy Markdown
Author

@robbiet480 The unknown station I see is a tag on a bus, which is consistent across agencies, but does not really have a station name.

For the crash I noticed that it has to do something with the TableView, not sure if that is a SwiftUI bug or has to do with how the data is deleted / repopulated when dismissing and presenting.

@robbiet480
Copy link
Copy Markdown
Owner

robbiet480 commented Aug 8, 2019

@timroesner If you have an Android device you should check out Metrodroid (free) and scan your card with it. My goal is, at least for Clipper, to exactly match Metrodroid and TransitPal's results. Would be interested to see what Metrodroid shows for that bus ride.

@timroesner
Copy link
Copy Markdown
Author

@robbiet480 Don’t have an Android to test on 😕 but maybe somebody from metrodroid can help?

Sent with GitHawk

@timroesner timroesner marked this pull request as ready for review August 9, 2019 04:56
@timroesner timroesner changed the title [WIP] Fix crash for single station trip Fix crash for single station trip Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants