fix: Endpoint "/v2/weather/{city}" error in model#50
Merged
robertoduessmann merged 1 commit intorobertoduessmann:masterfrom Apr 1, 2025
Merged
fix: Endpoint "/v2/weather/{city}" error in model#50robertoduessmann merged 1 commit intorobertoduessmann:masterfrom
robertoduessmann merged 1 commit intorobertoduessmann:masterfrom
Conversation
Closed
| wttrURL = "https://wttr.in" | ||
| ) | ||
|
|
||
| type wttrResponse struct { |
|
|
||
| var instance CacheManager = nil | ||
|
|
||
| func NewCacheManager() CacheManager { |
Owner
There was a problem hiding this comment.
Really nice cache implementation, I think it can be a really nice improvement.
I'm just wondering where/how exactly is this being used/invoked. Maybe I'm missing how this gets injected in the module.
robertoduessmann
approved these changes
Apr 1, 2025
Owner
robertoduessmann
left a comment
robertoduessmann
left a comment
There was a problem hiding this comment.
Gonna merge to fix the error in v2 🚀
Contributor
Author
|
Hi @robertoduessmann , I apologize for the delay in responding and also apologize because the Cache module was not complete. I was developing in parallel and ended up committing it accidentally. The idea was to create two classes for the Controllers and add the Cache Interface, using the Dependency Inversion concept. |
Owner
|
No worries @ranierelima I took your cache implementation as based and add this #56 to start using it 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed type of field "UvIndex" from
inttostring. Also created a new file for mapping of json response from API