Draft
Conversation
robertu94
reviewed
Feb 13, 2026
CMakeLists.txt
Outdated
| VERBATIM | ||
| ) | ||
| target_sources(libpressio PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/pressio_manual_register.cc) | ||
| #add_executable(pressio_register_generator src/pressio_register_generator.cc) |
Owner
There was a problem hiding this comment.
removing this will mean that you might be able to build a libpressio, but not one that can do anything. we can talk soon over zoom about this.
| auto s_roi_size = as<ssize_t>(roi_size); | ||
| std::array<size_t,1> center{center_ptr[0]}; | ||
| std::array<size_t,1> center{static_cast<size_t>(center_ptr[0])}; | ||
| auto s_center = as<ssize_t>(center); |
Owner
There was a problem hiding this comment.
In general the preference should be to handle these at a higher level of abstraction so fewer casts are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratchpad for the hacks needed to build libpressio for WASM. These hacks should be refined before actually merging anything.