Added new pathing check to see if it is imported#1
Open
binhonglee wants to merge 1 commit intorobm26:masterfrom
Open
Added new pathing check to see if it is imported#1binhonglee wants to merge 1 commit intorobm26:masterfrom
binhonglee wants to merge 1 commit intorobm26:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this isn't a node package, the only way to incorporate this into part of a package is to take out the
index.jsfile separately and putting it into whatever folder that's there. This is not ideal as the project would not get the latest version of this file when it gets updated here.By making this change, it will allow others to add this repository as a submodule instead of having to manually copy-pasting the file. I've used this for my own alexa skill and it seems to work even (and especially) for CI.
As for the inconsistencies of pathing (
./src/index.jsand../src/index.js), I'm not sure how it works but that's seems to be the only way it works for me.