Letterbox resolve to required resolution#1708
Closed
hardikdava wants to merge 6 commits intoroboflow:developfrom
hardikdava:develop
Closed
Letterbox resolve to required resolution#1708hardikdava wants to merge 6 commits intoroboflow:developfrom hardikdava:develop
hardikdava wants to merge 6 commits intoroboflow:developfrom
hardikdava:develop
Conversation
Contributor
|
Thank you for a quick submission! I'll take a deeper look whenever I can. Some preliminary notes:
|
Contributor
Author
|
@LinasKo Thanks for a quick look. I have talked with @onuralpszr and he is suggesting different idea of integration. I will wait for him first. |
Contributor
|
@hardikdava 👋 I talked with Linas and this is the new approach and he also asked me to add OBB and here is the PR #1711 |
Contributor
Author
|
@onuralpszr I saw that you already incorporated requirements for masks and oriented bounding box. Let's g with your PR. I am closing this one. c.c. @LinasKo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, supervision has
sv.letterbox_image()which resize images to get padded and with same aspect ratio image. But once this image used for detection task, then boxes has to be resized to original image in order to get correct scale and location of the boxes.List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
YOUR_ANSWER
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs
Script to reproduce results: