Open
Conversation
robohack
reviewed
Sep 28, 2023
Owner
robohack
left a comment
robohack
left a comment
There was a problem hiding this comment.
This looks interesting!
I'll have to think about how it might affect the existing API and whether it might need a version bump or not.
There should probably be some tests for the new functionality as well.
Author
|
I haven't really digged into the tests, but it looks to me like all tests available today could be run with this parsing as well, if a new flag is added to yajl_tests.c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently functionality to parse json byte-by-byte and parse full json string to json tree. This PR adds a merge of this functionality to it is possible to parse byte-by-byte and get a complete json tree when parsing is finished.