Skip to content

fix(prompt): separate review findings#698

Merged
wesm merged 2 commits intomainfrom
fix/issue-697
May 7, 2026
Merged

fix(prompt): separate review findings#698
wesm merged 2 commits intomainfrom
fix/issue-697

Conversation

@wesm
Copy link
Copy Markdown
Collaborator

@wesm wesm commented May 6, 2026

Summary

  • Adds an instruction in review prompt templates (default, dirty, range, security, plus claude-code/codex/gemini variants) telling agents to separate multiple findings with --- on its own line, so findings no longer render as a single block.
  • Adds TestGetSystemPrompt_ReviewPromptsRequireFindingSeparators to assert the separator instruction is present across all review prompt variants.
  • Refreshes prompt golden files to include the new line.

Fixes #697

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 6, 2026

roborev: Combined Review (1cce01d)

All review agents found no Medium, High, or Critical issues.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (b2a95b4)

Verdict: No Medium, High, or Critical issues found across the reviews.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit b7c521d into main May 7, 2026
8 checks passed
@wesm wesm deleted the fix/issue-697 branch May 7, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: review findings rendered as a single block (no separators between findings)

2 participants