fix(tui): show flash on clipboard copy failure#703
Merged
Conversation
Copy failures stored the error in m.err, which is never rendered, so pressing y on a Linux box without xclip/wl-clipboard installed produced no feedback at all. Surface the failure as a warning flash, mapping the atotto "No clipboard utilities available" error to a shorter, actionable hint. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TestHandleEnqueueExcludedCommitPattern's "range with corrupt mid-commit" subtest deleted a loose git object to break GetRangeCommits. On Windows that loose object isn't always where expected (auto-gc packing, AV latency), causing flaky "system cannot find the path specified" failures and at least one timeout on a recent main run. Replace the corruption mechanism: write a synthetic commit via hash-object whose parent line points at a SHA that does not exist, then update the branch ref to that synthetic tip. GetRangeCommits walks back from tip, fails to load the fake parent, and returns an error — same failure mode as before, with no dependency on .git/objects layout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m.err, which no view ever renders, so pressingyproduced no feedback at all.setWarningFlash(the same channel as the success flash).Copy failed: install xclip, wl-clipboard, or xsel. Other errors render asCopy failed: <err>.m.errfor debugging.🤖 Generated with Claude Code