ADDED socketIOPingInterval option to allow users to customise ping interval#151
Open
daveskybet wants to merge 1 commit intorobtaussig:masterfrom
Open
ADDED socketIOPingInterval option to allow users to customise ping interval#151daveskybet wants to merge 1 commit intorobtaussig:masterfrom
daveskybet wants to merge 1 commit intorobtaussig:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some SocketIO implementations have shorter ping interval requirements than the current fixed value constant.
This PR exposes a
socketIOPingIntervaloption which iffromSocketIOis true will pass a custom ping length down tosetUpSocketIOPing.It looks like most of the code was already implemented, and only required a single line change to allow the option to be passed in.