Addresses #265: fix minor bugs in Example Implementation#266
Open
darkhaniop wants to merge 1 commit intorobtaussig:masterfrom
Open
Addresses #265: fix minor bugs in Example Implementation#266darkhaniop wants to merge 1 commit intorobtaussig:masterfrom
darkhaniop wants to merge 1 commit intorobtaussig:masterfrom
Conversation
Addresses two minor bugs in the first usage example in README.md: - messageHistory state instantiation bug - WebSocketDemo markup Issue robtaussig#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two minor bugs described in #265:
1.
messageHistorystate instantiation bugThe
messageHistorystate instantiation updated to:2. The
WebSocketDemocomponent markupMade its output look a little more legible. Below is the example output after the fix in a blank app: