React starter with routing, params, query, mutations.#11
React starter with routing, params, query, mutations.#11winkler1 wants to merge 1 commit intorobzhu:masterfrom
Conversation
|
Oh looks like we both created a React-Apollo starter in parallel! I'll take a look tonight and see if we can just merge them together :] |
|
@stubailo Sounds good 👍 |
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Wouldn't an MIT license be better? This means any project started from this kit would be burdened with a more restrictive license.
There was a problem hiding this comment.
Sure, or maybe remove entirely? Just got created from create-react-app....
There was a problem hiding this comment.
Oh wow, that's really surprising that CRA adds the Apache license. I do think having a permissive license is important.
There was a problem hiding this comment.
My bad... CRA does not add a license; that came from GH on new repo
|
I think this example is a bit more in-depth than mine btw, the easiest thing might be to have both. |
|
Your code is more elegant (functional components; recompose is interesting). This one has an example mutation... |
2 participants
No description provided.