fix: add permalinkRow to RowsSnapshot and related functions for perma…#57
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the virtualizer’s permalink/deep-link handling by carrying the resolved permalink row through the rows snapshot (so the DOM row can be found via getRowKey even when it differs from the permalink id), and improves scroll-position persistence by flushing state immediately on scrollend (instead of only via debounce).
Changes:
- Add
permalinkRowtoRowsSnapshotand populate it during permalink anchoring. - Update pending-permalink scrolling to locate the DOM row by
getRowKey(permalinkRow)when available. - Persist scroll state immediately on
scrollend, and add DOM tests covering permalink key mismatch + persist timing.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/solid/create-zero-virtualizer.test.ts | Updates helper snapshot shape to include permalinkRow. |
| src/react/use-zero-virtualizer.test.ts | Updates helper snapshot shape to include permalinkRow. |
| src/core/virtualizer.ts | Implements key-based permalink row lookup and immediate persist on scrollend with refactoring into #writeScrollState. |
| src/core/virtualizer.test.ts | Updates helper snapshot shape to include permalinkRow. |
| src/core/virtualizer.dom.test.ts | Adds DOM tests for permalink row key mismatch and immediate persist-on-scrollend behavior. |
| src/core/rows.ts | Extends RowsSnapshot with permalinkRow and wires it up in assembleRows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1404
to
+1409
| #persistNow(): void { | ||
| clearTimeout(this.#persistTimer); | ||
| this.#persistTimer = undefined; | ||
| this.#lastPersistKey = this.#persistKey(); | ||
| this.#writeScrollState(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…link support