Make core library-agnostic while preserving everything else#63
Open
buzinas wants to merge 2 commits into
Open
Conversation
buzinas
force-pushed
the
library-agnostic-core
branch
from
b25fb51 to
21e1863
Compare
arv
reviewed
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Implements #61.
Description
This PR makes
corenot only framework-agnostic, but also library-agnostic. Before this PR,coredepends on@rocicorp/zero, but only its types are used opaquely. Now it uses an opaque genericTQuerytype instead, so any consumer can just pass the query shape their library use.The types that depended on
@rocicorp/zerowere moved tosrc/zero-types.tsand bothreactandsolidlibraries only change where they import the types from and nothing else.The goal here is to be able to make
corecompatible not only with Zero, but also with any other fetching library as React Query, Apollo GraphQL etc.