feat: add minPageSize option to control query page size#64
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new minPageSize option to the core virtualizer so consumers can set a lower bound for query page size (derived from viewport size), and documents/tests the behavior.
Changes:
- Introduces
minPageSizetoVirtualizerOptionsand uses it when computingpageSize. - Initializes
#pageSizefrom the configured minimum and keeps the existing “monotonic growth” behavior. - Adds unit tests and README documentation explaining how/when to tune page size for tall rows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core/virtualizer.ts | Adds minPageSize option and uses it as the page-size floor in #updatePageSize. |
| src/core/virtualizer.test.ts | Adds tests covering default/min/even rounding behavior for minPageSize. |
| README.md | Documents how page size is derived and when to adjust minPageSize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1019
to
+1022
| #minPageSize(): number { | ||
| const min = this.#options.minPageSize; | ||
| return min === undefined ? MIN_PAGE_SIZE : makeEven(Math.max(2, min)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.