feat: update minPageSize default from 100 to 50#66
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the core virtualizer’s default minPageSize floor to reduce the minimum query limit, aiming to decrease DOM/render work for tall-row UIs while keeping paging behavior consistent.
Changes:
- Lowered the core default
MIN_PAGE_SIZEfrom 100 to 50. - Updated unit tests to reflect the new default.
- Pinned
minPageSize: 100in the DOM harness test to keep existing paging expectations stable. - Updated README documentation to reflect the new default.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/solid/create-zero-virtualizer.test.ts | Updates Solid wrapper wiring test to accept the new default minimum page size. |
| src/core/virtualizer.ts | Changes the core default MIN_PAGE_SIZE constant from 100 to 50. |
| src/core/virtualizer.test.ts | Updates minPageSize contract tests for the new default value. |
| src/core/virtualizer.dom.test.ts | Pins minPageSize to 100 to preserve existing DOM paging expectations despite the new default. |
| README.md | Updates documentation describing the default minPageSize floor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The scroll-to-bottom test walks the list page by page. With 100-row pages that was 2 rounds, so each toPass attempt could afford the default 5s visibility wait. At 50-row pages the walk needs ~7 rounds and the long waits burn the 20s budget after ~4 — cap the per-attempt wait at 1s so the retry loop gets enough scroll rounds. Also update the stale 100-row references in comments and the minPageSize docstring. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.