Add fr-config-manager pull commands #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recorded mock record and updated snapshots for fr-config-manager commands. Ran lint:fix. Modified code for terms-and-conditions to use exising 'readConfigEntity' function, Changed saveJsonToFile argument from 'removeRev' to 'keepRev' for more general compatibility in other commands. Changed option names and added help messages, retesteed with the option name changes Changes fr-config export service-objects code to work with pre-existing functions. Fix PR to work with new library changes Run lint Remove dead code and separate out util functions Wording changes Removed direct RawApi calls
vscheuber
force-pushed
the
feature/config-manager-pull
branch
from
66f104a to
c52776f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in almost all fr-config-pull commands (there are some that were added after the majority of development for this was finished; these will be added in later). These commands should function as they do in fr-config-manager.
This PR relies on a few changes to the library, those can be found in this PR