Skip to content

feat: add permissions fields to FoundTableRowsDs and update use case logic #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Sep 16, 2025
Merged

feat: add permissions fields to FoundTableRowsDs and update use case logic #1359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions backend/src/entities/table/application/data-structures/found-table-rows.ds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ export class FoundTableRowsDs {
@ApiProperty()
allow_csv_import: boolean;

@ApiProperty()
can_delete: boolean;

@ApiProperty()
can_update: boolean;

@ApiProperty()
can_add: boolean;

@ApiProperty({ type: CreatedTableFilterRO, isArray: true })
saved_filters: Array<CreatedTableFilterRO>;
}
Expand Down
3 changes: 3 additions & 0 deletions backend/src/entities/table/use-cases/get-table-rows.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ export class GetTableRowsUseCase extends AbstractUseCase<GetTableRowsDs, FoundTa
allow_csv_export: allowCsvExport,
allow_csv_import: allowCsvImport,
saved_filters: savedTableFilters.map((el) => buildCreatedTableFilterRO(el)),
can_delete: tableSettings ? tableSettings.can_delete : true,
can_update: tableSettings ? tableSettings.can_update : true,
can_add: tableSettings ? tableSettings.can_add : true,
};

const identitiesMap = new Map<string, any[]>();
Expand Down
2 changes: 1 addition & 1 deletion backend/test/ava-tests/non-saas-tests/non-saas-table-oracledb-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2089,7 +2089,7 @@ test.serial(`${currentTest} should add row in table and return result`, async (t
t.is(getLogsRO.logs[addRowLogIndex].hasOwnProperty('affected_primary_key'), true);
t.is(typeof getLogsRO.logs[addRowLogIndex].affected_primary_key, 'object');
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.hasOwnProperty('id'), true);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, 43);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, String(43));
});

test.serial(`${currentTest} should throw an exception when connection id is not passed in request`, async (t) => {
Expand Down
2 changes: 1 addition & 1 deletion backend/test/ava-tests/non-saas-tests/non-saas-table-oracledb-schema-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2089,7 +2089,7 @@ test.serial(`${currentTest} should add row in table and return result`, async (t
t.is(getLogsRO.logs[addRowLogIndex].hasOwnProperty('affected_primary_key'), true);
t.is(typeof getLogsRO.logs[addRowLogIndex].affected_primary_key, 'object');
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.hasOwnProperty('id'), true);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, 43);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, String(43));
});

test.serial(`${currentTest} should throw an exception when connection id is not passed in request`, async (t) => {
Expand Down
2 changes: 1 addition & 1 deletion backend/test/ava-tests/saas-tests/table-oracle-agent-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ test.serial(`${currentTest} should add row in table and return result`, async (t
t.is(getLogsRO.logs[addRowLogIndex].hasOwnProperty('affected_primary_key'), true);
t.is(typeof getLogsRO.logs[addRowLogIndex].affected_primary_key, 'object');
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.hasOwnProperty('id'), true);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, 43);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, String(43));
});

test.serial(`${currentTest} should throw an exception when connection id is not passed in request`, async (t) => {
Expand Down
2 changes: 1 addition & 1 deletion backend/test/ava-tests/saas-tests/table-oracledb-schema-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2087,7 +2087,7 @@ test.serial(`${currentTest} should add row in table and return result`, async (t
t.is(getLogsRO.logs[addRowLogIndex].hasOwnProperty('affected_primary_key'), true);
t.is(typeof getLogsRO.logs[addRowLogIndex].affected_primary_key, 'object');
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.hasOwnProperty('id'), true);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, 43);
t.is(getLogsRO.logs[addRowLogIndex].affected_primary_key.id, String(43));
});

test.serial(`${currentTest} should throw an exception when connection id is not passed in request`, async (t) => {
Expand Down
Loading