Skip to content

Fix connections settings #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 3 commits into from
Nov 4, 2025
Merged

Fix connections settings #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a256cb9
connection settings: fix list of updated setting on amplitude even se…
lyubov-voloshko Nov 4, 2025
4539ffb
table settings: update Searchable foreign key columns hint
lyubov-voloshko Nov 4, 2025
6d5457a
Merge branch 'main' into fix-connections-settings
lyubov-voloshko Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/components/connection-settings/connection-settings.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export class ConnectionSettingsComponent implements OnInit {

for (const [key, value] of Object.entries(this.connectionSettings)) {
if (key === 'hidden_tables') {
updatedSettings[key] = value.length > 0;
updatedSettings[key] = value?.length > 0;
} else {
updatedSettings[key] = Boolean(value);
}
Expand Down
2 changes: 1 addition & 1 deletion ...app/components/dashboard/db-table-view/db-table-settings/db-table-settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ <h2 class="mat-heading-2" style="margin-bottom: -4px; margin-top: 12px">"Edit ro
[(ngModel)]="tableSettings.autocomplete_columns">
<mat-option *ngFor="let field of fields" [value]="field">{{field}}</mat-option>
</mat-select>
<mat-hint>Choose the columns Rocketadmin scans within a related table when using the foreign keys box.</mat-hint>
<mat-hint>Choose the columns Rocketadmin scans within a related table when selecting a foreign key.</mat-hint>
</mat-form-field>

<mat-form-field appearance="outline">
Expand Down