Skip to content

up deps#1423

Merged
gugu merged 2 commits into
mainfrom
vuln-fixes
Nov 7, 2025
Merged

up deps#1423
gugu merged 2 commits into
mainfrom
vuln-fixes

Conversation

@gugu

@gugu gugu commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@gugu gugu marked this pull request as ready for review November 7, 2025 11:14
Copilot AI review requested due to automatic review settings November 7, 2025 11:35
@gugu gugu enabled auto-merge (squash) November 7, 2025 11:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates multiple dependencies across the project, including security and feature updates for key packages like Angular, puppeteer, and various build tools. The changes primarily involve bumping package versions in package.json files and updating the corresponding lockfiles.

  • Updated ibm_db from ^3.3.0 to ^3.3.4 (with dependency updates to axios and nan)
  • Updated Angular build tools from 19.2.4/19.2.15 to 19.2.19
  • Updated puppeteer from ^23.10.4 to ^24.29.1 with major chromium-bidi updates
  • Added package resolutions for cipher-base and tar-fs in root package.json, and mermaid in frontend

Reviewed Changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Updates lockfile with new dependency versions including ibm_db, axios, cipher-base, tar-fs, and many transitive dependencies
rocketadmin-agent/package.json Updates ibm_db optional dependency from ^3.3.0 to ^3.3.4
package.json Adds resolutions for cipher-base (1.0.7) and tar-fs (1.16.6) to enforce specific versions
frontend/yarn.lock Updates Angular devkit packages, puppeteer ecosystem, mermaid and its dependencies, and various build tools
frontend/package.json Updates ngx-markdown, puppeteer, validator, and Angular build-angular; adds mermaid resolution
backend/tsconfig.json Reformats block comment to use line comments (formatting only)
backend/package.json Changes ibm_db from ^3.3.0 to exact version 3.3.0 (removes caret)
.yarnrc.yml Removes trailing whitespace (formatting only)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backend/package.json
},
"optionalDependencies": {
"ibm_db": "^3.3.0"
"ibm_db": "3.3.0"

Copilot AI Nov 7, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inconsistency detected: ibm_db is being updated to ^3.3.4 in the root package and rocketadmin-agent, but in backend/package.json it's being pinned to the exact version 3.3.0 (without the caret). This inconsistency could lead to different versions being installed in different parts of the project. Consider using a consistent version specifier across all locations (either ^3.3.4 or a specific version).

Suggested change
"ibm_db": "3.3.0"
"ibm_db": "^3.3.4"

Copilot uses AI. Check for mistakes.
@gugu gugu merged commit 86b7d8c into main Nov 7, 2025
15 of 20 checks passed
@gugu gugu deleted the vuln-fixes branch November 7, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants