Skip to content

refactor: disable isEmptyContent method for debug in AI insights #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Nov 14, 2025
Merged

refactor: disable isEmptyContent method for debug in AI insights #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions backend/src/entities/ai/use-cases/request-info-from-table-with-ai-v4.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,11 +410,12 @@ export class RequestInfoFromTableWithAIUseCaseV4
return true;
}

private isEmptyContent(content: string): boolean {
if (content === ' ') {
return false;
}
return !content || content.trim() === '';
private isEmptyContent(_content: string): boolean {
return false;
// if (content === ' ') {
// return false;
// }
// return !content || content.trim() === '';
Comment on lines +415 to +418

Copilot AI Nov 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented code after the return statement is unreachable and serves no purpose. If this is intended as temporary debug code, consider using a feature flag or configuration parameter instead of commenting out the implementation. For production code, remove the commented lines entirely.

Suggested change
// if (content === ' ') {
// return false;
// }
// return !content || content.trim() === '';

Copilot uses AI. Check for mistakes.
Comment on lines +413 to +418

Copilot AI Nov 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method now always returns false, which means the check at line 262 (if (this.isEmptyContent(chunk.delta))) will never filter out any content chunks. This causes all chunks, including potentially empty ones, to be written to the response stream. If this is temporary debug code, ensure it's not merged to production or use a configuration-based approach to toggle this behavior.

Suggested change
private isEmptyContent(_content: string): boolean {
return false;
// if (content === ' ') {
// return false;
// }
// return !content || content.trim() === '';
private isEmptyContent(content: string): boolean {
if (content === ' ') {
return false;
}
return !content || content.trim() === '';

Copilot uses AI. Check for mistakes.
}

private setupResponseHeaders(response: any): void {
Expand Down
Loading