more esm imports#1431
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR continues the migration to ESM (ECMAScript Module) imports in the frontend codebase by updating several import statements to use ESM-compatible paths and packages.
Key Changes:
- Added
lodash-espackage as a dependency and migrated one import fromlodashtolodash-es - Updated validator library imports to use ESM paths (
validator/es/lib/) - Enhanced mermaid dynamic import handling with a fallback pattern for default exports
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/package.json | Added lodash-es dependency for ESM support |
| frontend/yarn.lock | Updated lockfile to include lodash-es package |
| frontend/src/app/validators/hostname.validator.ts | Migrated validator imports to ESM paths |
| frontend/src/app/components/company/company.component.ts | Switched orderBy import from lodash to lodash-es |
| frontend/src/app/components/dashboard/db-table-view/db-table-ai-panel/db-table-ai-panel.component.ts | Added fallback handling for mermaid default export |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.