sso: remove id property from initial sso config#1438
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the id property optional in the SamlConfig interface and removes it from the initial configuration object. This change allows creating new SAML configurations without requiring an ID upfront, while still maintaining the ID for existing configurations that need to be updated.
- Made
idproperty optional in theSamlConfiginterface - Removed the
idfield from thesamlConfigInitialobject in the SSO component - Reordered imports for better organization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/app/models/company.ts | Made id property optional in SamlConfig interface; reorganized imports |
| frontend/src/app/components/sso/sso.component.ts | Removed id field from initial SAML configuration object; reorganized imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.