Fixes#1439
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements several fixes including styling improvements for SSO checkboxes and enhanced CSV export functionality with proper foreign key handling.
- Adds CSS styling to align SSO configuration checkboxes consistently
- Implements validation to prevent CSV export when no rows are selected
- Updates CSV export logic to properly extract primary key values from foreign key objects
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/app/components/sso/sso.component.html | Applies CSS class to active and authnResponseSignedValidation checkboxes for consistent styling |
| frontend/src/app/components/sso/sso.component.css | Defines styling for checkbox elements with margin adjustments |
| frontend/src/app/components/dashboard/db-table-view/db-table-view.component.ts | Adds selection validation and implements foreign key value extraction in CSV export functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Check if this field is a foreign key | ||
| if (this.isForeignKey(fieldName) && value && typeof value === 'object') { | ||
| // Get the foreign key definition | ||
| const foreignKey = this.tableData.foreignKeys[fieldName]; |
There was a problem hiding this comment.
Missing null safety: The code accesses this.tableData.foreignKeys[fieldName] without checking if this.tableData.foreignKeys exists. If foreignKeys is undefined or null, this will throw a runtime error. Consider adding a check like this.tableData.foreignKeys && this.tableData.foreignKeys[fieldName] or using optional chaining this.tableData.foreignKeys?.[fieldName].
| const foreignKey = this.tableData.foreignKeys[fieldName]; | |
| const foreignKey = this.tableData.foreignKeys?.[fieldName]; |
No description provided.