Skip to content

sso: add Assertions signed validation checkbox #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 2 commits into from
Nov 19, 2025
Merged

sso: add Assertions signed validation checkbox #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0486d05
sso: add Assertions signed validation checkbox
lyubov-voloshko Nov 19, 2025
90f2b1b
Merge branch 'main' into fixes
lyubov-voloshko Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/components/sso/sso.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}

.samlConfigForm__checkbox {
margin-top: -4px;
margin-top: -8px;
margin-bottom: 20px;
}

Expand Down
15 changes: 12 additions & 3 deletions frontend/src/app/components/sso/sso.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,22 @@ <h1 class="mat-h1 ssoPageHeader">
Active
</mat-checkbox>

<mat-checkbox name="assertionsSignedValidation" #assertionsSignedValidation="ngModel"
class="samlConfigForm__checkbox"
data-testid="assertionsSignedValidation-checkbox"
labelPosition="after"
[disabled]="submitting"
[(ngModel)]="samlConfig.assertionsSignedValidation">
Assertions signed validation
</mat-checkbox>

<mat-checkbox name="authnResponseSignedValidation" #authnResponseSignedValidation="ngModel"
class="samlConfigForm__checkbox"
data-testid="authnResponseSignedValidation-checkbox"
labelPosition="after"
[disabled]="submitting"
[(ngModel)]="samlConfig.authnResponseSignedValidation">
Authn Response Signed Validation
Authn response signed validation
</mat-checkbox>

<mat-form-field appearance="outline">
Expand All @@ -96,7 +105,7 @@ <h1 class="mat-h1 ssoPageHeader">
[(ngModel)]="samlConfig.allowedDomains">
</mat-form-field>
<mat-form-field appearance="outline">
<mat-label>Display Name</mat-label>
<mat-label>Display name</mat-label>
<input matInput name="display-name" #displayName="ngModel"
data-testid="display-name-input"
required
Expand All @@ -112,7 +121,7 @@ <h1 class="mat-h1 ssoPageHeader">
[(ngModel)]="samlConfig.logoUrl">
</mat-form-field>
<mat-form-field appearance="outline">
<mat-label>Expected Issuer</mat-label>
<mat-label>Expected issuer</mat-label>
<input matInput name="expected-issuer" #expectedIssuer="ngModel"
data-testid="expected-issuer-input"
required
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/app/components/sso/sso.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ export class SsoComponent implements OnInit {
signatureAlgorithm: '',
digestAlgorithm: "sha256",
active: true,
authnResponseSignedValidation: true,
authnResponseSignedValidation: false,

Copilot AI Nov 19, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for authnResponseSignedValidation changed from true to false. This is a breaking change that could affect security if existing configurations rely on the previous default behavior. If this change is intentional, ensure that existing SAML configurations are migrated appropriately, or consider keeping the default as true for security reasons.

Suggested change
authnResponseSignedValidation: false,
authnResponseSignedValidation: true,

Copilot uses AI. Check for mistakes.
assertionsSignedValidation: false,
allowedDomains: [],
displayName: '',
logoUrl: '',
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/app/models/company.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export interface SamlConfig {
signatureAlgorithm: string;
digestAlgorithm: "sha256",
active: true,
Comment on lines 71 to 72

Copilot AI Nov 19, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type inconsistency: digestAlgorithm and active are defined with literal type values ("sha256" and true) instead of their proper types (string and boolean). This prevents them from accepting other valid values. Consider changing to:

digestAlgorithm: string,
active: boolean,
Suggested change
digestAlgorithm: "sha256",
active: true,
digestAlgorithm: string,
active: boolean,

Copilot uses AI. Check for mistakes.
authnResponseSignedValidation: true,
authnResponseSignedValidation: boolean,
assertionsSignedValidation: boolean,
allowedDomains: string[],
displayName: string,
logoUrl: string,
Expand Down
Loading