Skip to content

Saas and mobile fixes#1490

Merged
lyubov-voloshko merged 3 commits into
mainfrom
saas-and-mobile-fixes
Dec 24, 2025
Merged

Saas and mobile fixes#1490
lyubov-voloshko merged 3 commits into
mainfrom
saas-and-mobile-fixes

Conversation

@lyubov-voloshko

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings December 24, 2025 12:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds '127.0.0.1' to the saasHostnames array in the development environment configuration to fix issues related to SaaS and mobile functionality.

  • Adds '127.0.0.1' to the saasHostnames array in environment.dev.ts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apiRoot: "https://app.rocketadmin.com/api",
saasURL: "https://app.rocketadmin.com",
saasHostnames: ['localhost'],
saasHostnames: ['localhost', '127.0.0.1'],

Copilot AI Dec 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding '127.0.0.1' to saasHostnames in the dev environment is a good fix, but the same addition should also be made to environment.saas.ts and environment.saas-prod.ts for consistency. Both of those files currently have saasHostnames arrays with 'localhost' but are missing '127.0.0.1'. This inconsistency could lead to different behavior when the application runs on 127.0.0.1 vs localhost in different environments, even though they resolve to the same address.

Copilot uses AI. Check for mistakes.
@lyubov-voloshko lyubov-voloshko merged commit 81c0ece into main Dec 24, 2025
17 checks passed
@lyubov-voloshko lyubov-voloshko deleted the saas-and-mobile-fixes branch December 24, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants