Skip to content

fix: extract filename from path in S3 widget preview #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gugu merged 2 commits into from
Feb 10, 2026
Merged

fix: extract filename from path in S3 widget preview #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2661ca
fix: extract filename from path in S3 widget preview
gugu Feb 10, 2026
0e42b3a
Merge branch 'main' into fix/s3-widget-filename-display
gugu Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/components/ui-components/record-edit-fields/s3/s3.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
} @else if (previewUrl()) {
<div class="s3-widget__file-icon">
<mat-icon>insert_drive_file</mat-icon>
<span class="s3-widget__filename">{{(internalValue() || value()) | slice:-30}}</span>
<span class="s3-widget__filename">{{displayFilename()}}</span>
</div>
}
</div>
Expand Down
7 changes: 7 additions & 0 deletions frontend/src/app/components/ui-components/record-edit-fields/s3/s3.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ export class S3EditComponent implements OnInit {
}
});

readonly displayFilename = computed(() => {
const val = this.internalValue() || this.value();
if (!val) return '';
const name = val.split('/').pop() || val;
return name.length > 40 ? '...' + name.slice(-37) : name;
Comment on lines +75 to +76

Copilot AI Feb 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

displayFilename uses magic numbers (40 and 37) to implement truncation. Consider extracting these into named constants (e.g., maxDisplayLength / tailLength) so the intent is clearer and future changes don’t risk off-by-one mistakes.

Copilot uses AI. Check for mistakes.
});
Comment on lines +72 to +77

Copilot AI Feb 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add/adjust unit tests for the new displayFilename computed behavior. There are existing component/spec tests, but they currently only assert that the filename element exists; they should now assert that a path-like key (e.g., uploads/document.pdf) renders just document.pdf, and that long filenames are truncated according to the new 40-char/ellipsis logic.

Copilot uses AI. Check for mistakes.

readonly isImage = computed(() => {
const p = this.params();
const val = this.internalValue() || this.value();
Expand Down
Loading