fix: add proper font fallback stack to theme typography config#1605
Merged
Conversation
Prevents UI from jumping to the browser default font when Noto Sans fails to load. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a proper font fallback stack to prevent UI rendering issues when the primary font (Noto Sans) fails to load. The change centralizes the font-family definition into a reusable SCSS variable with a complete fallback chain that gracefully degrades through standard system fonts.
Changes:
- Introduces
$app-font-familyvariable containing 'Noto Sans' with fallbacks: 'Helvetica Neue', Helvetica, Arial, and sans-serif - Replaces hardcoded 'Noto Sans' strings across all Angular Material typography level definitions with the new variable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents UI from jumping to the browser default font when Noto Sans fails to load.