-
-
Notifications
You must be signed in to change notification settings - Fork 18
Table list ordering #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Table list ordering #1617
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
37af117
folders: update logic in new endpoint
lyubov-voloshko 51de557
tables list: changing order inside a table
lyubov-voloshko 59efb31
tables list: insert folder in the position user drops it
lyubov-voloshko f8d2e5a
refactor and fix table name formatting
lyubov-voloshko dead6b3
tables list: restore folders expanded state after clear Search
lyubov-voloshko 812f28c
footer: update year
lyubov-voloshko 7410af9
fix unit tests
lyubov-voloshko df5d1fe
Merge branch 'main' into table-list-ordering
lyubov-voloshko 3315cf9
tables list: show All tables from from server respond
lyubov-voloshko 596a7f9
tables list: update id of All tables folder
lyubov-voloshko cbd1b0d
tables list: update All tables id in html and fix folder menu button
lyubov-voloshko 853a8d2
Merge branch 'main' into table-list-ordering
lyubov-voloshko 7c4d9d1
fix unit tests
lyubov-voloshko 64c3010
Merge branch 'table-list-ordering' of https://github.com/rocket-admin…
lyubov-voloshko 4dd1520
Merge branch 'main' into table-list-ordering
lyubov-voloshko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing error handling for the fetchTablesFolders API call. The previous async/await implementation had a try-catch block that handled errors by setting isServerError and serverError properties. Without error handling, if the API call fails, the application may be left in an inconsistent state without informing the user. Add error handling using the catchError operator or a second callback in the subscribe method.