-
-
Notifications
You must be signed in to change notification settings - Fork 18
Auto ai settings improvements #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,6 +104,79 @@ | |
| margin: 0; | ||
| } | ||
|
|
||
| .ai-config-alert { | ||
| display: flex; | ||
| gap: 8px; | ||
| background-color: color-mix(in hsl, var(--color-accentedPalette-500), transparent 95%); | ||
| backdrop-filter: blur(4px); | ||
| border-top: 1px solid var(--color-accentedPalette-500); | ||
| border-right: 1px solid var(--color-accentedPalette-500); | ||
| border-bottom: 1px solid var(--color-accentedPalette-500); | ||
| border-left: 12px solid var(--color-accentedPalette-500); | ||
| border-radius: 4px; | ||
| padding: 12px 16px 12px 8px; | ||
| } | ||
|
Comment on lines
+107
to
+118
|
||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .ai-config-alert { | ||
| backdrop-filter: blur(2px); | ||
| } | ||
| } | ||
|
|
||
| @media (width <= 600px) { | ||
| .ai-config-alert { | ||
| display: grid; | ||
| grid-template-columns: auto 1fr; | ||
| } | ||
| } | ||
|
|
||
| .ai-config-alert__icon { | ||
| flex-shrink: 0; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| border-radius: 50%; | ||
| color: var(--color-accentedPalette-500); | ||
| font-size: 24px; | ||
| height: 36px; | ||
| opacity: 0.9; | ||
| width: 36px; | ||
| } | ||
|
|
||
| .ai-config-alert__message { | ||
| flex: 1; | ||
| display: flex; | ||
| justify-content: center; | ||
| flex-direction: column; | ||
| min-height: 36px; | ||
| margin: 0 !important; | ||
| } | ||
|
|
||
| .ai-config-alert__title { | ||
| color: var(--color-accentedPalette-500); | ||
| margin-bottom: 4px; | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .ai-config-alert__title { | ||
| color: inherit; | ||
| } | ||
| } | ||
|
|
||
| .ai-config-alert__text { | ||
| margin: 0 !important; | ||
| } | ||
|
|
||
| .ai-config-alert__actions { | ||
| margin-left: auto; | ||
| } | ||
|
|
||
| @media (width <= 600px) { | ||
| .ai-config-alert__actions { | ||
| grid-column: 1 / -1; | ||
| } | ||
| } | ||
|
|
||
| .error-details { | ||
| margin-top: 8px; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -82,7 +82,16 @@ <h3 class='mat-subheading-2'>Rocketadmin can not find any tables</h3> | |||||||||||||||||||||||
| <div class="table-preview-content"> | ||||||||||||||||||||||||
| <div class="alerts"> | ||||||||||||||||||||||||
| <app-alert></app-alert> | ||||||||||||||||||||||||
| <app-alert *ngIf="dataSource.alert_settingsInfo" [alert]="dataSource.alert_settingsInfo"></app-alert> | ||||||||||||||||||||||||
| <div *ngIf="dataSource.alert_settingsInfo" class="ai-config-alert"> | ||||||||||||||||||||||||
| <mat-icon class="ai-config-alert__icon">auto_awesome</mat-icon> | ||||||||||||||||||||||||
| <div class="ai-config-alert__message mat-body-1"> | ||||||||||||||||||||||||
| <strong class="ai-config-alert__title">New: AI Configuration</strong> | ||||||||||||||||||||||||
| <p class="ai-config-alert__text">Automatically configure all your tables with AI. You can adjust changes in Settings and UI widgets.</p> | ||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||
| <div class="ai-config-alert__actions"> | ||||||||||||||||||||||||
| <a mat-button [routerLink]="'/auto-configure/' + connectionID">Configure all</a> | ||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||
|
Comment on lines
+85
to
+94
|
||||||||||||||||||||||||
| <div *ngIf="dataSource.alert_settingsInfo" class="ai-config-alert"> | |
| <mat-icon class="ai-config-alert__icon">auto_awesome</mat-icon> | |
| <div class="ai-config-alert__message mat-body-1"> | |
| <strong class="ai-config-alert__title">New: AI Configuration</strong> | |
| <p class="ai-config-alert__text">Automatically configure all your tables with AI. You can adjust changes in Settings and UI widgets.</p> | |
| </div> | |
| <div class="ai-config-alert__actions"> | |
| <a mat-button [routerLink]="'/auto-configure/' + connectionID">Configure all</a> | |
| </div> | |
| </div> | |
| <app-alert *ngIf="dataSource.alert_settingsInfo" [alert]="dataSource.alert_settingsInfo"></app-alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an “Open tables” navigation while
loading()remains true means users can leave before_configure()resolves. The current component logic navigates to/dashboard/:idwhen the async call completes; without cancellation/teardown guarding, that navigation can still fire after the component is destroyed (potentially causing unexpected redirects or state resets). Also,connectionId()starts asnull, so this routerLink can briefly become/dashboard/null; consider rendering/enabling the button only onceconnectionId()is set.