Skip to content

Add ordering by creation date to user connection queries #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Apr 6, 2026
Merged

Add ordering by creation date to user connection queries #1704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/src/entities/connection/repository/custom-connection-repository-extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ export const customConnectionRepositoryExtension: IConnectionRepository &
.leftJoinAndSelect('connection.groups', 'group')
.leftJoinAndSelect('group.users', 'user')
.leftJoinAndSelect('connection.connection_properties', 'connection_properties')
.andWhere('user.id = :userId', { userId: userId });
.andWhere('user.id = :userId', { userId: userId })
.orderBy('connection.createdAt', 'DESC');
Comment on lines 41 to +43

Copilot AI Apr 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering solely by createdAt can be nondeterministic when multiple connections share the same timestamp (e.g., bulk inserts / same DB transaction timestamp). Consider adding a secondary deterministic sort key (via addOrderBy) to ensure stable results when createdAt ties.

Copilot uses AI. Check for mistakes.
Comment on lines +42 to +43

Copilot AI Apr 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a user-visible ordering contract (newest connections first) but existing e2e tests around GET /connections don’t appear to assert ordering. Adding/adjusting an e2e assertion would prevent regressions (especially around test vs non-test connections).

Copilot uses AI. Check for mistakes.
if (!includeTestConnections) {
connectionQb.andWhere('connection.isTestConnection = :isTest', { isTest: false });
}
Expand All @@ -54,7 +55,8 @@ export const customConnectionRepositoryExtension: IConnectionRepository &
.leftJoinAndSelect('group.users', 'user')
.leftJoinAndSelect('connection.connection_properties', 'connection_properties')
.andWhere('user.id = :userId', { userId: userId })
.andWhere('connection.isTestConnection = :isTest', { isTest: true });
.andWhere('connection.isTestConnection = :isTest', { isTest: true })
.orderBy('connection.createdAt', 'DESC');
Comment on lines 57 to +59

Copilot AI Apr 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: ordering only by createdAt can produce unstable ordering when timestamps tie. Add a secondary deterministic ordering (e.g., addOrderBy) here as well so test-connection lists are stable.

Copilot uses AI. Check for mistakes.
const connections = await connectionQb.getMany();
await decryptConnectionsCredentialsAsync(connections);
return connections;
Expand Down
Loading