Skip to content

Minor fixes #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 2 commits into from
Apr 16, 2026
Merged

Minor fixes #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e561020
tables list: add tooltip for long table names
lyubov-voloshko Apr 16, 2026
2ad7247
branding page: add router module import
lyubov-voloshko Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/app/components/branding/branding.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { DeleteDomainDialogComponent } from '../company/delete-domain-dialog/del
import { ProfileSidebarComponent } from '../profile/profile-sidebar/profile-sidebar.component';
import { PlaceholderBrandingComponent } from '../skeletons/placeholder-branding/placeholder-branding.component';
import { AlertComponent } from '../ui-components/alert/alert.component';
import { RouterModule } from '@angular/router';

@Component({
selector: 'app-branding',
Expand All @@ -32,6 +33,7 @@ import { AlertComponent } from '../ui-components/alert/alert.component';
MatButtonModule,
MatIconModule,
MatTooltipModule,
RouterModule,
Angulartics2OnModule,
AlertComponent,
ProfileSidebarComponent,
Expand Down
37 changes: 21 additions & 16 deletions frontend/src/app/components/dashboard/db-tables-list/db-tables-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,22 +39,23 @@

<!-- Collapsed table list for any folder -->
<div *ngIf="showCollapsedTableList" class="collapsed-tables-list">
<a *ngFor="let tableItem of getCollapsedTableList()"
class="collapsed-table-item"
routerLink="/dashboard/{{connectionID}}/{{tableItem.table}}"
[queryParams]="{page_index: 0, page_size: 30}"
[ngClass]="{'collapsed-table-item_active': selectedTable === tableItem.table}"
<div *ngFor="let tableItem of getCollapsedTableList()"
[matTooltip]="getTableName(tableItem)"
matTooltipPosition="right"
(click)="closeSidebar()">
<!-- Show icon if available, otherwise show initials -->
<mat-icon *ngIf="tableItem.icon; else tableNameInitials" class="table-list-icon">
{{tableItem.icon}}
</mat-icon>
<ng-template #tableNameInitials>
{{tableItem.initials}}
</ng-template>
</a>
matTooltipPosition="right">
<a class="collapsed-table-item"
Comment on lines +42 to +45

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matTooltip is attached to the wrapping <div> (not the <a>), but the <div> is not focusable. This means keyboard users focusing the link won’t get the tooltip on focus (regression vs when tooltip was on the anchor). Move the tooltip bindings onto the <a> or make the tooltip host focusable (e.g., tabindex="0") and ensure focus/aria behavior is correct.

Copilot uses AI. Check for mistakes.
routerLink="/dashboard/{{connectionID}}/{{tableItem.table}}"
[queryParams]="{page_index: 0, page_size: 30}"
[ngClass]="{'collapsed-table-item_active': selectedTable === tableItem.table}"
(click)="closeSidebar()">
<!-- Show icon if available, otherwise show initials -->
<mat-icon *ngIf="tableItem.icon; else tableNameInitials" class="table-list-icon">
{{tableItem.icon}}
</mat-icon>
<ng-template #tableNameInitials>
{{tableItem.initials}}
</ng-template>
</a>
</div>
</div>
</div>

Expand Down Expand Up @@ -110,7 +111,9 @@
class="material-symbols-outlined folder-icon"
[style.color]="folder.iconColor || null">folder</span>

<div class="folder-name">
<div class="folder-name"
[matTooltip]="folder.name"
[matTooltipDisabled]="folder.name.length <= 18">
{{folder.name}}
</div>

Expand Down Expand Up @@ -148,6 +151,8 @@
(cdkDropListDropped)="onTableReorder($event, folder)">
<div *ngFor="let table of getFolderTables(folder)"
class="selected-table-item"
[matTooltip]="getTableName(table)"
[matTooltipDisabled]="getTableNameLength(getTableName(table)) <= 18"
cdkDrag
Comment on lines 152 to 156

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip is placed on .selected-table-item (a <div> without tabindex), while the interactive element is the inner <a>. As a result, the tooltip won’t appear when navigating via keyboard focus on the link. Consider moving matTooltip/matTooltipDisabled onto the <a> (or the .table-name span) so it triggers on focus as well as hover.

Copilot uses AI. Check for mistakes.
Comment on lines +154 to 156

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within the *ngFor this introduces multiple method calls per row (getTableName(table) is invoked for matTooltip, again inside matTooltipDisabled, and again in the link text). This can add noticeable change-detection cost for large lists. Prefer computing the value once (e.g., via *ngIf="getTableName(table) as tableName" and reusing tableName, or by precomputing a tableName field in the data).

Copilot uses AI. Check for mistakes.
[cdkDragDisabled]="!isReorderingEnabled(folder)">
<mat-icon *ngIf="isReorderingEnabled(folder)"
Expand Down
Loading