Skip to content

refactor(docker): remove unused database service configurations and update test command#1852

Merged
Artuomka merged 1 commit into
mainfrom
backend_tests
Jun 30, 2026
Merged

refactor(docker): remove unused database service configurations and update test command#1852
Artuomka merged 1 commit into
mainfrom
backend_tests

Conversation

@Artuomka

@Artuomka Artuomka commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved test command handling so extra arguments are passed correctly during containerized test runs.
  • Chores
    • Simplified the default test setup by narrowing which non-core database/search/cache test suites run by default.
    • Removed several rarely used test services from the compose-based test environment to keep it lighter and faster.

Copilot AI review requested due to automatic review settings June 30, 2026 14:33
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd299f52-fc41-45b1-8b6a-014e5b0cde4d

📥 Commits

Reviewing files that changed from the base of the PR and between ad48b86 and e5dddc7.

📒 Files selected for processing (2)
  • docker-compose.tst.yml
  • justfile

📝 Walkthrough

Walkthrough

The PR removes eight database/search/cache e2e service definitions from docker-compose.tst.yml, quotes $EXTRA_ARGS in the backend test command, and narrows the default test glob in justfile to exclude oracle, ibmdb2, cassandra, elasticsearch, mssql, mongo, redis, dynamodb, and clickhouse test files.

Changes

CI Test Scope Narrowing

Layer / File(s) Summary
Test runner command and default glob
docker-compose.tst.yml, justfile
Quotes "$EXTRA_ARGS" in the backend pnpm test-all-parallel invocation with explanatory comments; narrows the justfile default args to a negated glob excluding nine database engine test files; removes test-mongo-e2e-testing, mssql-e2e-testing, test-oracle-e2e-testing, test-cassandra-e2e-testing, test-redis-e2e-testing, test-ibm-db2-e2e-testing, test-dynamodb-e2e-testing, test-clickhouse-e2e-testing, and test-elasticsearch-e2e-testing service definitions from the compose file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • lyubov-voloshko

Poem

🐇 Hop, hop, away with the clutter!
Nine database services gone in a flutter.
The glob now says "nope" to mongo and mssql,
A cleaner CI suite — no drama, no fuss.
Less compose, more speed, the rabbit approves! 🎉

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: removing unused database test service configs and updating the test command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed The change only touches test infra, quotes EXTRA_ARGS to prevent shell globbing/injection, and removes unused test DB containers, reducing attack surface.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backend_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Docker-based backend test setup to reduce CI resource usage by running only the Postgres/MySQL (and DB-agnostic) test subset, and removes the now-unused heavy database service definitions from the test Compose file.

Changes:

  • Update just test default AVA glob to exclude non-Postgres/MySQL database suites.
  • Remove MSSQL/Oracle/Mongo/DB2/etc service configurations from docker-compose.tst.yml.
  • Quote $EXTRA_ARGS in the backend test command so the glob is passed to AVA intact.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
justfile Changes the default test glob (and adds guidance) to avoid running suites that require heavy DB containers in CI.
docker-compose.tst.yml Removes unused DB services and updates the backend command to safely pass the AVA glob via $EXTRA_ARGS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread justfile
Comment on lines +1 to +6
# CI default runs only the Postgres + MySQL (and DB-agnostic) suites — the
# other database engines (Oracle, MSSQL, Mongo, IBM DB2, Cassandra, Redis,
# DynamoDB, ClickHouse, Elasticsearch) are excluded so their heavy containers
# aren't needed. Pass an explicit glob to run a different subset locally, e.g.
# just test 'test/ava-tests/non-saas-tests/*mongo*.test.ts'
test args='test/ava-tests/non-saas-tests/!(*oracle*|*ibmdb2*|*cassandra*|*elasticsearch*|*mssql*|*mongo*|*redis*|*dynamodb*|*clickhouse*).test.ts':
@Artuomka Artuomka merged commit 7e6c052 into main Jun 30, 2026
18 checks passed
@Artuomka Artuomka deleted the backend_tests branch June 30, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants