refactor(docker): remove unused database service configurations and update test command#1852
Conversation
…pdate test command
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR removes eight database/search/cache e2e service definitions from ChangesCI Test Scope Narrowing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR refactors the Docker-based backend test setup to reduce CI resource usage by running only the Postgres/MySQL (and DB-agnostic) test subset, and removes the now-unused heavy database service definitions from the test Compose file.
Changes:
- Update
just testdefault AVA glob to exclude non-Postgres/MySQL database suites. - Remove MSSQL/Oracle/Mongo/DB2/etc service configurations from
docker-compose.tst.yml. - Quote
$EXTRA_ARGSin the backend test command so the glob is passed to AVA intact.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
justfile |
Changes the default test glob (and adds guidance) to avoid running suites that require heavy DB containers in CI. |
docker-compose.tst.yml |
Removes unused DB services and updates the backend command to safely pass the AVA glob via $EXTRA_ARGS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # CI default runs only the Postgres + MySQL (and DB-agnostic) suites — the | ||
| # other database engines (Oracle, MSSQL, Mongo, IBM DB2, Cassandra, Redis, | ||
| # DynamoDB, ClickHouse, Elasticsearch) are excluded so their heavy containers | ||
| # aren't needed. Pass an explicit glob to run a different subset locally, e.g. | ||
| # just test 'test/ava-tests/non-saas-tests/*mongo*.test.ts' | ||
| test args='test/ava-tests/non-saas-tests/!(*oracle*|*ibmdb2*|*cassandra*|*elasticsearch*|*mssql*|*mongo*|*redis*|*dynamodb*|*clickhouse*).test.ts': |
Summary by CodeRabbit