fix(cicd): bump stack to Node 22 (TW v4 / @tailwindcss/oxide need >=20)#153
Merged
Conversation
The previous prepare-release run still failed at the @rocketicons/tailwind integration test even with `npm ci` because the runner was on Node 18, and @tailwindcss/oxide@4.2.1 (TW v4's native Rust core, loaded via @tailwindcss/postcss) requires Node >=20 — its native binary refuses to load on 18 with "Cannot find native binding". Same constraint applies to Next.js 15 and the rest of the v4 stack we just adopted. Changes: - All four GitHub workflows: NODE_VERSION 18.x -> 22.x. - Add `.nvmrc` pinning local dev to Node 22 (matches CI). - Set engines.node ">=20" on the three published packages (rocketicons, @rocketicons/tailwind, @rocketicons/utils) so consumers installing the new release on Node 18 get a clear warning instead of a runtime crash from oxide. Verified locally on Node 22.19.0: - npm run test-all: 79 tests pass (utils 22 + tailwind 57) - npm run lint-all: no warnings/errors - npm run --workspaces typecheck: all 6 packages clean - npm run build-all: ignition Next 15 build completes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second attempt to unblock the v0.5.0 release pipeline. Previous fix (#152, switching to
npm ci) didn't help because the actual root cause is the Node engine mismatch, not the lockfile resolution.Root cause
Logs from the most recent failed
prepare-releaserun reveal:@tailwindcss/oxideis TW v4's Rust-based native core, loaded transitively through@tailwindcss/postcssbypackages/tailwind's integration test. Its prebuilt.nodebinary refuses to load on Node <20 — that's the "Cannot find native binding" we saw at runtime.Next.js 15 also recommends Node 20+, and the rest of the v4 stack (NativeWind 4, Expo SDK we adopted in
packages/native-test) is happiest on a recent Node.Changes
All four GitHub workflows:
NODE_VERSION18.x→22.xprepare-release.ymlrelease.ymlprepare-preview.ymlpublish-ignition.yml(defaultnode-versioninput).nvmrcadded at repo root pinning local dev to Node 22 — matches CIengines.node: ">=20"on the three currently-published packages:rocketicons(packages/icons)@rocketicons/tailwind@rocketicons/utilsConsumers installing the new release on Node 18 will get a clear
EBADENGINEwarning at install time instead of a confusing runtime crash from oxide. (We chose>=20not>=22for the engines floor — that's the actual constraint from TW v4'soxiderather than our dev-environment preference.)Why Node 22 (not 20)
22 is current LTS (since Oct 2024) and matches the user's local dev machine. CI on 22 mirrors local. No reason to pin lower.
Verified locally on Node 22.19.0
npm run test-all— 79 tests pass (utils 22 + tailwind plugin 57)npm run lint-all— no warnings/errors across all 6 workspacesnpm run --workspaces --if-present typecheck— all cleannpm run build-all— ignition Next.js 15 build completes (SKIP_GENERATOR_BUILD=truesince icons are pre-built)After merge
PR #151 (develop → main) will auto-resync and
prepare-releasere-runs against develop on Node 22 —@tailwindcss/oxideshould load, integration tests should pass, the releaser should produce a clean tag artifact.