fix(vxfw): out of bounds panic on ScrollBars#343
Merged
Conversation
rockorager
approved these changes
May 25, 2026
Owner
rockorager
left a comment
rockorager
left a comment
There was a problem hiding this comment.
LGTM. The mouse drag coordinates are signed, so using <= 0 correctly handles dragging past the top/left before converting through float to u32 scroll positions. I also ran locally on the PR branch.
Contributor
Author
|
@rockorager dude that was crazy fast. Thanks for the review |
Owner
|
AI ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a scrollbar with enough force and determination can cause
new_thumb_topandnew_thumb_col_startto be negative (both arei16), which causes an out of bounds panic when assigning to au32on L194 and L254.