Added tag "[itemaction] set slot material amount"#417
Open
JustusJG wants to merge 1 commit intorockyhawk64:mainfrom
Open
Added tag "[itemaction] set slot material amount"#417JustusJG wants to merge 1 commit intorockyhawk64:mainfrom
JustusJG wants to merge 1 commit intorockyhawk64:mainfrom
Conversation
Owner
|
Thanks for the PR. Just flagging why this isn't merged yet, which is due to the maintenance scope this opens up. A basic set action for just material and amount would immediately have people wanting custom model data, item model, display name, lore, and so on. Without those this feature has limited use for most servers, but supporting it means maintaining a full item builder inside CommandPanels. The current internal item builder that creates panels is technically able to do this with something like the following code snippet, but it adds necessary custom persistent data into the items that will break stacking with other Non-CommandPanels items in players inventories: if (action.equalsIgnoreCase("set")) {
InventoryPanelBuilder tempBuilder = new InventoryPanelBuilder(ctx, player);
ItemBuilder builder = new ItemBuilder(ctx, tempBuilder);
item = builder.buildItem(panel,
((InventoryPanel)panel).getItems().get(args[2]));
}Not closing this yet but wanted to flag why it hasn't been merged for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #415