Skip to content

Added tag "[itemaction] set slot material amount"#417

Open
JustusJG wants to merge 1 commit intorockyhawk64:mainfrom
JustusJG:main
Open

Added tag "[itemaction] set slot material amount"#417
JustusJG wants to merge 1 commit intorockyhawk64:mainfrom
JustusJG:main

Conversation

@JustusJG
Copy link
Copy Markdown

@JustusJG JustusJG commented Dec 8, 2025

Issue: #415

@rockyhawk64
Copy link
Copy Markdown
Owner

rockyhawk64 commented Apr 9, 2026

Thanks for the PR. Just flagging why this isn't merged yet, which is due to the maintenance scope this opens up. A basic set action for just material and amount would immediately have people wanting custom model data, item model, display name, lore, and so on. Without those this feature has limited use for most servers, but supporting it means maintaining a full item builder inside CommandPanels.

The current internal item builder that creates panels is technically able to do this with something like the following code snippet, but it adds necessary custom persistent data into the items that will break stacking with other Non-CommandPanels items in players inventories:

if (action.equalsIgnoreCase("set")) {
    InventoryPanelBuilder tempBuilder = new InventoryPanelBuilder(ctx, player);
    ItemBuilder builder = new ItemBuilder(ctx, tempBuilder);
    item = builder.buildItem(panel,
        ((InventoryPanel)panel).getItems().get(args[2]));
}

Not closing this yet but wanted to flag why it hasn't been merged for now.

@rockyhawk64 rockyhawk64 mentioned this pull request Apr 9, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants