Only copy files if they exist#479
Conversation
|
Thanks, appreciated! In case you need further changes, can you please wait until tomorrow? We are trying to get the 9.0 preview out of the door and the CI bandwidth per project is limited and our CI takes a long time even without bandwidth limitations, so this slows us down a bit. We might also cancel your CI runs to prioritise ours - we will restart them then when we are finished. |
Yes, will wait until tomorrow. Sorry I thought I had tested the first run, but I had changed the wrong file. |
|
No issue at all - I just wanted to explain that we might do unexpected things. |
MSoegtropIMC
left a comment
MSoegtropIMC
left a comment
There was a problem hiding this comment.
In summary, we should review the way the icon is retrieved and make it independent of CoqIDE rather than adding logic which depends on if CoqIDE is there or not.
The change for CompCert is fine, thanks!
There was a problem hiding this comment.
@jim-portegies : I guess the two icon files are the same and coq-shell.ico always exists, so I think we should always use this one and remove the ifs.
There was a problem hiding this comment.
I do think the icons are in fact different
There was a problem hiding this comment.
Yes, I remember that one should be a console icon with a Coq on top of it.
There was a problem hiding this comment.
My comment is more or less the same as above: instead of switching between various icons, we should just make the method to retrieve the icon independend of CoqIDE.
There was a problem hiding this comment.
@MSoegtropIMC I agree, shall I try to make an update to the PR?
There was a problem hiding this comment.
Yes, please. It would be nice if installers for older version still would get the old icon.
2 participants
So far, building the Windows installer through the script
create_windows_installer.shfailed when either Coqide was not installed or when compcert was not installed. This PR aims to fix that.