feat(tables): TablesAPI.upload for /v1/tables/upload/

[jadenfix]

Summary

• New client.tables.upload(table_name, file, with_headers=True, organization_id=None) API.
• file accepts str | Path | bytes | BinaryIO | FileUpload; mime-guesses to text/csv for .csv names.
• Regenerated _generated/api/tables/upload_table.py + TableUploadRequest / TableUploadResponse models from the backend openapi.
• Wired into RoeClient.tables property + module __init__ exports.

Backend PR: https://github.com/roe-ai/roe-main/pull/3245

Test Plan

• tests/unit/test_tables.py — 2 unit tests passing (bytes path multipart shape + RoeClient property wiring).
• Live upload against the dev stack with /Users/jadenfix/secondary_agent_results_v2.csv returns 201 with 7 written rows; confirmed in ClickHouse.
• Existing tests still pass (uv run pytest tests/).

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR adds TablesAPI.upload() — a new public method that accepts a CSV file in several forms (str | Path | bytes | BinaryIO | FileUpload) and POSTs it to the new /v1/tables/upload/ endpoint as a multipart request. It also ships the generated OpenAPI client (upload_table.py, TableUploadRequest, TableUploadResponse) and wires RoeClient.tables as a property.

• TablesAPI._as_generated_file() correctly handles each input type, guesses the MIME type, and flags which streams to close after the request — file descriptor management is sound.
• The generated models (table_upload_request.py, table_upload_response.py, upload_table.py) carry several duplicate and unused imports that were flagged in prior review threads and remain unaddressed.
• to_multipart() in TableUploadRequest has two known serialisation bugs flagged previously: the None org-id branch sends the literal string "None" instead of omitting the field, and the UUID branch is the only one that omits .encode() on its string value.

Confidence Score: 4/5

Safe to merge after addressing the previously flagged to_multipart() serialisation bugs; the TablesAPI wrapper itself guards against both issues at the call site.

The high-level TablesAPI.upload() path is correct: it always passes a real UUID (never None) to TableUploadRequest, so the b"None" multipart bug flagged in the previous thread can only be triggered by callers who construct TableUploadRequest directly. The generated files still carry duplicate/unused import noise and the inconsistent encoding in the UUID branch. The resp.parsed result is not guarded against unexpected 2xx responses, which would silently return None to the caller.

The three generated files (upload_table.py, table_upload_request.py, table_upload_response.py) still need the cleanup from the prior review threads; table_upload_request.to_multipart() in particular has the None-as-UUID serialisation bug for direct consumers of the generated model.

Important Files Changed

Filename	Overview
src/roe/api/tables.py	New TablesAPI wrapper; file-type coercion and close-on-exit logic are correct; resp.parsed is not guarded against unexpected 2xx returning None
src/roe/_generated/models/table_upload_request.py	Generated model; contains duplicate imports, unused imports (BinaryIO, TextIO, TYPE_CHECKING, Generator), and the UUID branch in to_multipart() is missing .encode() unlike all other branches
src/roe/_generated/api/tables/upload_table.py	Generated endpoint file; has duplicate from typing import cast imports (lines 4 and 15) and an unused from urllib.parse import quote import
src/roe/_generated/models/table_upload_response.py	Generated response model; has duplicate from ..types import UNSET, Unset import and several unused typing imports (BinaryIO, TextIO, TYPE_CHECKING, Generator)
src/roe/client.py	Cleanly wires TablesAPI into RoeClient via a cached instance and a typed property
openapi/openapi.yml	Adds /v1/tables/upload/ POST endpoint schema with correct request/response shapes; summary field intentionally left without a type (any)

Sequence Diagram

sequenceDiagram
    participant Caller
    participant TablesAPI
    participant _as_generated_file
    participant TableUploadRequest
    participant upload_table
    participant Backend

    Caller->>TablesAPI: upload(table_name, file, ...)
    TablesAPI->>TablesAPI: resolve organization_id → UUID or UNSET
    TablesAPI->>_as_generated_file: coerce file type
    _as_generated_file-->>TablesAPI: File(payload, ...), close_after
    TablesAPI->>TableUploadRequest: build(table_name, file, with_headers, org_id)
    TableUploadRequest->>TableUploadRequest: to_multipart() → RequestFiles
    TablesAPI->>upload_table: sync_detailed(client, body)
    upload_table->>Backend: POST /v1/tables/upload/ (multipart/form-data)
    Backend-->>upload_table: 201 TableUploadResponse / 400 ErrorResponse
    upload_table-->>TablesAPI: "Response[ErrorResponse | TableUploadResponse]"
    TablesAPI->>TablesAPI: translate_response (raise on non-2xx)
    TablesAPI->>TablesAPI: close payload if close_after
    TablesAPI-->>Caller: TableUploadResponse

Loading

_{Reviews (2): Last reviewed commit: "revert(generated): undo manual generated..." | Re-trigger Greptile}

[jadenfix]

@greptile review

[jadenfix]

Closing per request.